Combining NFT and ERC-20 token transfers in a single transaction

NFT
1

Hey everyone! I’m trying to figure out if it’s possible to transfer both an ERC-1155 or ERC-721 NFT along with an ERC-20 token in a single transaction. Has anyone accomplished this? Any advice or revised code examples would be really helpful as I’m still learning the ropes of blockchain programming.

Here’s a revised example I’m considering:

function sendAssets(address recipient, uint256 nftId, uint256 tokenAmount) public {
    // Transfer the NFT
    customNFT.safeTransferFrom(msg.sender, recipient, nftId);
    
    // Transfer the ERC-20 token
    customToken.transfer(recipient, tokenAmount);
}

Could someone let me know if this strategy is valid or if there are pitfalls to be aware of? Thanks in advance for your insights!

2

hey dancingcloud! thats a really interesting question :eyes: i’ve been experimenting with something similar lately

your approach looks pretty good to me! one thing to keep in mind tho - make sure you have the necessary approvals set up before calling that function. the msg.sender needs to have approved your contract to transfer both the nft and tokens on their behalf

also, have u considered using a batch transfer function for the nft if youre using erc-1155? could be more gas efficient if youre transferring multiple nfts at once

btw, how are u handling errors? might wanna add some checks to make sure both transfers succeed. maybe something like:

require(customNFT.safeTransferFrom(msg.sender, recipient, nftId), "NFT transfer failed");
require(customToken.transfer(recipient, tokenAmount), "Token transfer failed");

just a thought! what kinda project are u working on? sounds pretty cool combining nfts and tokens like that. lemme know if u wanna brainstorm ideas sometime!

3

yo dancingcloud, that’s pretty neat! i’ve done smthing similar before. ur code looks solid, but watch out for gas costs. they can sneak up on ya when combining transfers. maybe try batching if ur dealing with lots of assets? also, don’t forget to handle errors properly. keep us posted on how it goes!

4

Your approach is sound, but there are a few considerations to keep in mind. Firstly, ensure that your contract has the necessary permissions to transfer assets on behalf of the sender. This typically involves calling approve() or setApprovalForAll() beforehand.

Secondly, consider implementing a check to verify that both transfers were successful. You can do this by capturing the return values of the transfer functions and using require statements.

Lastly, be aware of potential reentrancy vulnerabilities when dealing with multiple token transfers. Consider implementing checks-effects-interactions pattern or using a reentrancy guard to mitigate this risk.

For gas optimization, you might want to look into batching multiple transfers if you’re dealing with numerous assets. This can significantly reduce transaction costs for users.