How can I trade all NFT items except the locked ones?

NFT
1

I’m developing a platform for trading digital collectibles and need guidance on implementing the trading logic. The goal is to create a method that enables users to trade all their NFTs but bypass those that are locked or have trading limitations.

This is what I am aiming for:

function tradeAvailableNFTs(wallet, recipient) {
    const tradableTokens = [];
    
    for (const nft of wallet.nfts) {
        if (!nft.locked && nft.canTrade) {
            tradableTokens.push(nft.id);
        }
    }
    
    return initiateTrade(tradableTokens, recipient);
}

Is my strategy correct for managing NFT trades when some tokens are subject to restrictions? I want to ensure I have covered all essential checks before proceeding with the trades.

2

Hey @CreativePainter45! Your approach looks solid, but I’m curious about a few things that might cause issues…

What happens if someone tries trading while another transaction’s still pending? I’ve seen NFTs get flagged as tradeable but fail mid-transaction due to timing. You planning any transaction state checking?

Also wondering - how do you determine the canTrade property? On-chain or database? If it’s database-driven, you might get sync issues with actual blockchain state.

Another thought - what about gas estimation? Trading multiple NFTs gets expensive fast on Ethereum. Consider adding gas limit checks or batching trades based on network conditions?

Quick question - handling royalty payments or creator fees? Some collections have those built in and they affect trade execution.

Love to hear more about your platform! Sounds like an interesting project.

3

looks good but dont forget to check nft approval status too! this bit me before - token showed as tradable but the wallet hadnt approved the contract yet. maybe add an nft.isApproved check? also worth wrapping initiateTrade in try/catch since individual nfts can fail for random reasons.

4

Your implementation covers the basics, but I’d add ownership verification before the trading loop. I’ve built similar systems and learned you need to validate the wallet actually owns each NFT at execution time - ownership changes between query and execution. Also throw in a cooldown mechanism. Some NFT contracts restrict transfers based on recent activity. Found this out the hard way when my trades kept failing silently. One more issue: you’re processing all eligible NFTs in one transaction. Works fine for small collections but gas limits will kill you on larger batches. Add pagination or split trades when gas estimates exceed network limits. Otherwise you’ll burn gas fees on failed transactions.