What's the proper way to implement NFT purchases using ERC721?

NFT
1

Hey everyone! I’m working on an NFT project and I’m stuck on how to set up a buying feature. I’ve got the minting part down using OpenZeppelin’s ERC721Full, but I can’t figure out how to let users buy NFTs.

I tried writing a buyNFT function, but it’s not working because of the approve function restrictions. Here’s what I’ve got so far:

function purchaseToken(uint tokenId) public payable {
    address payable seller = address(uint160(ownerOf(tokenId)));
    approve(seller, tokenId);
    setApprovalForAll(msg.sender, true);
    transferFrom(seller, msg.sender, tokenId);
    seller.transfer(msg.value);
    emit TokenSold(seller, msg.sender, msg.value);
}

I know this isn’t right, but I’m not sure how to structure a buy function correctly. Should I be overriding the approve function? That feels wrong.

Can anyone point me in the right direction for implementing NFT purchases? I want to get it working before adding extra checks and requirements. Thanks!

2

Hey BrilliantCoder39! i’m super curious about your NFT project. sounds like you’ve got the basics down but hit a snag with the buying part. have you considered using a marketplace contract as a middleman? that way, sellers can list their nfts and buyers can purchase through the marketplace. it might simplify things a bit.

what kind of nfts are you creating, btw? i’d love to hear more about the concept! maybe we could brainstorm some ideas for the buying process that fit your specific project?

oh, and don’t forget to think about gas fees when implementing purchases. that can be a tricky part to get right. what’s your plan for handling those?

3

I’ve implemented NFT purchases in a recent project, and here’s what worked for me: separate the listing and buying processes. Create a ‘listForSale’ function where the seller approves the contract and sets a price. Then, in your ‘purchaseToken’ function, check if the token is listed, verify the payment amount, and execute the transfer. This approach maintains proper access control and prevents unauthorized transfers.

Remember to include safety checks like ensuring the token exists and is actually for sale. Also, consider implementing a withdrawal pattern for sellers to claim their funds, rather than sending Ether directly in the purchase function. This can help mitigate potential security risks.

Lastly, thoroughly test your contract with various scenarios before deployment. Security is paramount when dealing with NFTs and financial transactions.

4

yo, ive run into this before. ur on the right track, but the buyer shouldnt be approving or setting approval. thats the sellers job. try having a separate ‘listForSale’ function where the seller approves the contract. then in ‘purchaseToken’, just do the transfer n payment. hope this helps!